Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using docker multi-stage for 50% smaller image #1091

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Using docker multi-stage for 50% smaller image #1091

merged 1 commit into from
Sep 26, 2019

Conversation

max-rocket-internet
Copy link
Contributor

A simple PR to change the Dockerfile to use a multi-stage build. This reduces docker image size from 286MB to 127MB.

@mbeacom mbeacom added the LGTM label Sep 26, 2019
mbeacom
mbeacom approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@mbeacom mbeacom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

Thanks for the contribution @max-rocket-internet

@mbeacom mbeacom merged commit 7b4553d into locustio:master Sep 26, 2019
@max-rocket-internet max-rocket-internet deleted the docker_builder branch September 26, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeacom mbeacom mbeacom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-rocket-internet @mbeacom