Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for Dockerfile #1093

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Improvements for Dockerfile #1093

merged 1 commit into from
Oct 1, 2019

Conversation

coderanger
Copy link
Contributor

Installs from the local code rather than a release version, creates a non-root user, and switches from entrypoint to cmd for better customization.

@coderanger
Improvements for Dockerfile.
089a60f 
Installs from the local code rather than a release version, creates a non-root user, and switches from entrypoint to cmd for better customization.
@max-rocket-internet
Copy link
Contributor

Installs from the local code rather than a release version

Nice! I was going to make a PR for this also.

If we resolve #849 and merge #1083 then we might finally have nice official docker option for locust.

mbeacom
mbeacom approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@mbeacom mbeacom merged commit b3a6d85 into locustio:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeacom mbeacom mbeacom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderanger @max-rocket-internet @mbeacom