Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow 1 percent codecov degradation before failing build (because it is flaky) #1230

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Jan 16, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #1230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files          20       20           
  Lines        1955     1955           
  Branches      308      308           
=======================================
  Hits         1538     1538           
  Misses        336      336           
  Partials       81       81
Impacted Files Coverage Δ
locust/util/deprecation.py 85% <0%> (ø) ⬆️
locust/contrib/fasthttp.py 91.17% <0%> (ø) ⬆️
locust/web.py 89.05% <0%> (ø) ⬆️
locust/main.py 34.42% <0%> (ø) ⬆️
locust/core.py 87.71% <0%> (ø) ⬆️
locust/runners.py 78.33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f1f6f...013f4ae. Read the comment docs.

@cyberw
Copy link
Collaborator Author

cyberw commented Jan 16, 2020

Great, we had just the right amount of flakyness in the build to validate my change :P

@cyberw cyberw merged commit f2d26fd into master Jan 16, 2020
@cyberw cyberw deleted the allow-1-percent-codecov-degradation-before-failing-build-(because-it-is-flaky) branch January 28, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant