Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load shape worker in headless. #1539

Merged
merged 2 commits into from
Aug 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions locust/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,8 @@ def timelimit_stop():
# start the test
if options.step_time:
runner.start_stepload(options.num_users, options.spawn_rate, options.step_users, options.step_time)
if environment.shape_class:
environment.runner.start_shape()
else:
runner.start(options.num_users, options.spawn_rate)

Expand Down
2 changes: 0 additions & 2 deletions locust/test/mock_locustfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ class UserSubclass(HttpUser):
class NotUserSubclass():
host = "http://localhost:8000"

class LoadTestShape(LoadTestShape):
pass
'''

class MockedLocustfile:
Expand Down
40 changes: 38 additions & 2 deletions locust/test/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from locust.argument_parser import parse_options
from locust.main import create_environment
from locust.user import HttpUser, User, TaskSet
from .mock_locustfile import mock_locustfile
from .mock_locustfile import mock_locustfile, MOCK_LOUCSTFILE_CONTENT
from .testcases import LocustTestCase
from .util import temporary_file, get_free_tcp_port

Expand Down Expand Up @@ -48,6 +48,7 @@ def test_load_locust_file_from_absolute_path(self):
self.assertIn('UserSubclass', user_classes)
self.assertNotIn('NotUserSubclass', user_classes)
self.assertNotIn('LoadTestShape', user_classes)
self.assertIsNone(shape_class)

def test_load_locust_file_from_relative_path(self):
with mock_locustfile() as mocked:
Expand All @@ -64,7 +65,18 @@ def test_return_docstring_and_user_classes(self):
self.assertIn('UserSubclass', user_classes)
self.assertNotIn('NotUserSubclass', user_classes)
self.assertNotIn('LoadTestShape', user_classes)


def test_with_shape_class(self):
content = MOCK_LOUCSTFILE_CONTENT + '''class LoadTestShape(LoadTestShape):
pass
'''
with mock_locustfile(content=content) as mocked:
docstring, user_classes, shape_class = main.load_locustfile(mocked.file_path)
self.assertEqual("This is a mock locust file for unit testing", docstring)
self.assertIn('UserSubclass', user_classes)
self.assertNotIn('NotUserSubclass', user_classes)
self.assertEqual(shape_class.__class__.__name__, 'LoadTestShape')

def test_create_environment(self):
options = parse_options(args=[
"--host", "https://custom-host",
Expand Down Expand Up @@ -190,6 +202,30 @@ def test_default_headless_spawn_options(self):
).decode("utf-8").strip()
self.assertIn("Spawning 1 users at the rate 1 users/s", output)

def test_default_headless_spawn_options_with_shape(self):
content = MOCK_LOUCSTFILE_CONTENT + '''
class LoadTestShape(LoadTestShape):
def tick(self):
run_time = self.get_run_time()
if run_time < 2:
return (10, 1)

return None
'''
with mock_locustfile(content=content) as mocked:
output = subprocess.check_output(
["locust",
"-f", mocked.file_path,
"--host", "https://test.com/",
"--run-time", "1s",
"--headless"],
stderr=subprocess.STDOUT,
timeout=3,
).decode("utf-8").strip()
self.assertIn("Shape test updating to 10 users at 1.00 spawn rate", output)
self.assertIn("Cleaning up runner...", output)


def test_web_options(self):
port = get_free_tcp_port()
if platform.system() == "Darwin":
Expand Down