Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in events.py example #159

Merged
merged 3 commits into from
May 16, 2014
Merged

Fixed typos in events.py example #159

merged 3 commits into from
May 16, 2014

Conversation

nawaidshamim
Copy link
Contributor

bugfix in the events.py example script

@heyman
Copy link
Member

heyman commented May 16, 2014

Hi,

Actually, there's no need to use the global keyword. You can read variables from the outer scope, and since stats in this case points to a dict, you can modify that dict. You don't actually reassign the stats variable.

@nawaidshamim
Copy link
Contributor Author

Yes you are right. I tried with list before and it didn't work.
Although stats should be data in on_slave_report() method

@heyman
Copy link
Member

heyman commented May 16, 2014

Yeah, that's true. If you remove the global keywords I'd be happy to merge :). Thanks!

@nawaidshamim
Copy link
Contributor Author

Done! Now you can merge ;) Thanks!

heyman added a commit that referenced this pull request May 16, 2014
Fixed typos in events.py example
@heyman heyman merged commit e15106e into locustio:master May 16, 2014
@heyman
Copy link
Member

heyman commented May 16, 2014

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants