Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception when calling response.success()/.failure() if with-block has not been entered #1955

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Throw exception when calling response.success()/.failure() if with-block has not been entered #1955

merged 4 commits into from
Dec 8, 2021

Commits on Dec 8, 2021

  1. Throw exception if someone tries to call response.failure()/success()… 

    … without using a with block. Committing tests-first for validation.
    @cyberw
    cyberw committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    c79533d View commit details
    Browse the repository at this point in the history

  2. Throw an exception if someone tries to call response.failure()/succes… 

    …s() without using a with block (helps with some misunderstandings, e.g. #1953)
    @cyberw
    cyberw committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    ceb2cf2 View commit details
    Browse the repository at this point in the history

  3. Tests: Fix usage of assertRaises

    @cyberw
    cyberw committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    409d4a6 View commit details
    Browse the repository at this point in the history

  4. fix test

    @cyberw
    cyberw committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    0642063 View commit details
    Browse the repository at this point in the history