Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Report: Implement table sorting #2134

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Test Report: Implement table sorting #2134

merged 3 commits into from
Jul 19, 2022

Conversation

Likqez
Copy link
Contributor

@Likqez Likqez commented Jul 14, 2022

This PR implements the following feature request #2132.

It enables sorting the statistic tables by clicking on the respective table headers.
To make the headers clickable, the class sortable needs to be applied. This makes it possible to ex-/include columns from being sort-able.

I only excluded the error messages as well as the stacktraces from being sort-able from now on.
Changes are welcome.

@cyberw
Copy link
Collaborator

cyberw commented Jul 18, 2022

LGTM. But why not have error messages sortable?

@Likqez
Copy link
Contributor Author

Likqez commented Jul 18, 2022

Seemed unnecessary to me. Added it with the latest commit.

@cyberw cyberw merged commit a37a9b2 into locustio:master Jul 19, 2022
@cyberw
Copy link
Collaborator

cyberw commented Jul 19, 2022

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants