Log a warning for failed attempts to connect to master #2136
Conversation
|
Maybe make it debug the first 2 times and then warning level? Dont wanna spam the user in what is a normal scenario (master is often not available at the very start), and error should be reserved for catastrophic fails. |
|
Sure, I will change it as I am not familiar with how log levels are used in Locust and this change should indeed not break consistency.
"2" is not a magic number that will cover all situations, I'd rather have everything with same level but will do as you suggested for now. I would probably make retries and delay between retries configurable (in a separate PR), but at least with this one the on-going failures will stop being completely concealed. |
|
Lgtm, except for the formatting/black issue. |
The connection timeout and number of attempts are hardcoded, so a failure will take very long These log lines will allow to troubleshoot issues with the connection to master
|
Oh, my bad, I had missed that; fixed now. |
cyberw
changed the title
The connection timeout and number of attempts are hardcoded (60 attempts with an interval of 5 seconds each), so a complete failure of the worker to connect to master will take very long.
These log lines will allow to troubleshoot issues with the connection to master.