Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the CustomMessageListener class for type consistency #2221

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Delete the CustomMessageListener class for type consistency #2221

merged 3 commits into from
Oct 12, 2022

Conversation

samuelspagl
Copy link
Contributor

This PR is the conclusion of #2208.
It deletes the CustomMessageListener class for type consistency and adds Callable type hint instead.

@samuelspagl
Copy link
Contributor Author

@cyberw ping

I used Callable instead of any as I think it is a bit more concise. Hope that's okay.
Looking forward to your comments.

@cyberw
Copy link
Collaborator

cyberw commented Oct 12, 2022

Definitely good enough. Thanks!

@cyberw cyberw merged commit 83c07d0 into locustio:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelspagl @cyberw