-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customization Feature for Percentile Display on Statistics Page #2550
Merged
cyberw
merged 25 commits into
locustio:master
from
FooQoo:feature/user-editable-statics-columns
Jan 16, 2024
Merged
Changes from 10 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9b2e6e4
Add .venv to .gitignore for Python virtual environment exclusion
FooQoo 7db0504
Implement user-editable columns in statics screen
FooQoo e7282f5
Remove ninetyNinthResponseTime
FooQoo 374e10a
Correct statics to statistics
FooQoo bb6cfb2
Merge branch 'master' into feature/user-editable-statics-columns
FooQoo f0ff2e7
Apply ruff formatting
FooQoo f6ee8ad
Add unittests for normalize_decimal
FooQoo 1bb11b4
Add integration test
FooQoo b95a03b
Apply ruff formatting for test_main.py
FooQoo a8d483c
Revert changes to percentile display from 50%ile back to original
FooQoo 3981277
Update configuration docs
FooQoo c47c2a6
Implement column visibility toggle feature in modern UI
FooQoo 75ffdd5
Remove export of tableStructure
FooQoo 2d6ced9
Add validation for PERCENTILES_TO_STATISTICS
FooQoo e02b0b6
Remove unnecessary comment
FooQoo 061dbcb
Reverting table component to original
FooQoo 6458cde
Added function to useSelectViewColumns hook for excluding columns
FooQoo 1966c67
Build webui
FooQoo 5c5d17a
Add unittest for filterStructure
FooQoo 0cb9a62
Revert legacy UI
FooQoo 4b5d2ac
Update configuration docs of PERCENTILES_TO_STATISTICS
FooQoo 29974c3
Capitalize description of parameters in configuration docs
FooQoo 07b7ae7
Format import
FooQoo c214bec
Aggregate table structure filtering logic within hook
FooQoo 5cd7d62
Build frontend
FooQoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,3 +27,4 @@ __pycache__ | |
.sass-cache/ | ||
.env | ||
yarn-error.log | ||
.venv |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,9 @@ | ||
def proper_round(val, digits=0): | ||
return round(val + 10 ** (-len(str(val)) - 1), digits) | ||
|
||
|
||
def normalize_decimal(value): | ||
if isinstance(value, float) and value.is_integer(): | ||
return int(value) | ||
else: | ||
return value |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
78 changes: 39 additions & 39 deletions
78
locust/webui/dist/assets/index-ea7131ad.js → locust/webui/dist/assets/index-fd9ede73.js
Large diffs are not rendered by default.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
...t/webui/dist/assets/index-ea7131ad.js.map → ...t/webui/dist/assets/index-fd9ede73.js.map
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest you change this to "list of response time percentiles to show in the statistics table"
And maybe remove "The" from all descriptions, I dont know why that is in there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead maybe add something about this and PERCENTILES_TO_CHART being UI settings (just to make it clear)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyberw
I've updated the descriptions for PERCENTILES_TO_CHART and PERCENTILES_TO_STATISTICS as suggested.
3981277