Remove legacy UI #2703
Merged
Remove legacy UI #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrewbaldwin44
commented
May 6, 2024
•
andrewbaldwin44
commented
- Remove words "legacy" and "modern" from codebase as we only have one UI now
- Remove legacy-ui and modern_ui flags
- Remove logic for rendering legacy UI
- Remove templates and static assets for legacy UI
- Update UI tests to suit the modern UI
- Update documentation to only include logic for modern UI
- Ensured modern UI, web login, HTML report, and downloaded HTML report all continue to work as expected
andrewbaldwin44
force-pushed
the
task/2673
branch
5 times, most recently
from
1778381
to
f9fe009
Compare
|
Nice! Can we keep the argument around (and hide it using help=configargparse.SUPPRESS), and exit with an error message if someone sets it? |
andrewbaldwin44
force-pushed
the
task/2673
branch
3 times, most recently
from
2e7577d
to
2294b2f
Compare
cyberw
reviewed
May 6, 2024
locust/main.py
Outdated
| @@ -183,7 +179,8 @@ def is_valid_percentile(parameter): | |||
| options.spawn_rate = options.hatch_rate | |||
|
|
|||
| if options.legacy_ui: | |||
| sys.stderr.write("[DEPRECATED] The legacy UI is deprecated and will be removed soon\n") | |||
| sys.stderr.write("[DEPRECATED] The legacy UI is deprecated") | |||
There was a problem hiding this comment.
I think "deprecated" usually means "going to be deleted, but still works", so this line is confusing :)
andrewbaldwin44
commented
May 6, 2024
| ) | ||
| self.assertRegex(response.text, re_spawn_rate) | ||
| self.assertNotRegex(response.text, re_disabled_spawn_rate) | ||
|
|
There was a problem hiding this comment.
These regex tests are being removed because they are covered by our frontend tests
andrewbaldwin44
commented
May 6, 2024
| self.assertEqual( | ||
| self.environment.available_user_classes["User1"].json(), | ||
| {"host": "http://localhost", "tasks": ["my_task_2"], "fixed_count": 0, "weight": 1}, | ||
| ) |
There was a problem hiding this comment.
These tests were just moved to join the base Web UI tests
|
LGTM. Especially if you add I'll want to hold off a day or two on merging though, because I'd like to release the changes already merged as a separate release. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.