Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuild UI in PyPi publish steps so that even source distributions contain web UI code #2839

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mquinnfd
Copy link
Contributor

@mquinnfd mquinnfd commented Aug 6, 2024

Overview

Ensures that sdist tarball contains web UI code, this is necessary for things such as the brew installation of Locust.

Example run of sdist build and tar unwrap with this added step:
https://github.com/mquinnfd/locust/actions/runs/10271769131

Example sdist build without web UI:
https://pypi.org/project/locust/2.31.1/#files

@mquinnfd mquinnfd marked this pull request as ready for review August 6, 2024 19:00
@cyberw cyberw merged commit bb38eab into locustio:master Aug 6, 2024
14 checks passed
@cyberw
Copy link
Collaborator

cyberw commented Aug 6, 2024

Nice! If it works out I'll make a new release right away.

@cyberw cyberw changed the title Prebuild UI in PyPi publish steps Prebuild UI in PyPi publish steps so that even source distributions contain web UI code Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants