Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support horizontal scrolling for the stats table #938

Merged
merged 1 commit into from
Dec 29, 2018

Conversation

mingrammer
Copy link
Contributor

I can't see the last column in the stat table when the name is long. So I think locust web should support the horizontal scrolling on the stats table.

@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #938 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #938   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files          14       14           
  Lines        1438     1438           
  Branches      226      226           
=======================================
  Hits          957      957           
  Misses        430      430           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777d1cc...0449fb1. Read the comment docs.

@cgoldberg cgoldberg merged commit 6c8eb37 into locustio:master Dec 29, 2018
@myzhan
Copy link
Contributor

myzhan commented Feb 15, 2019

This change makes the stats table look like this, it's weird. Can we make it look better?

image

@mingrammer mingrammer deleted the horizontal-scroll branch February 15, 2019 06:22
@cgoldberg
Copy link
Member

cgoldberg commented Feb 15, 2019

@myzhan can you PR an improvement? I'd like to get it looking better.

@myzhan
Copy link
Contributor

myzhan commented Feb 15, 2019

I'm trying to revert the previous change, and added this.

#stats {
    table-layout: fixed;
}

#stats td {
    word-wrap: break-word;
}

Long text will be broke into multiple lines.

image

And you can use the browser's window scrolling to see the whole table if your browser's window is small.

shot

What do you think? @cgoldberg @mingrammer

@myzhan
Copy link
Contributor

myzhan commented Feb 15, 2019

And @cgoldberg , I can commit to the same branch if you are willing to merge #945

Or I will checkout a new branch.

@mingrammer
Copy link
Contributor Author

@myzhan I agree! That would be better.

@cgoldberg
Copy link
Member

create a new PR for the changes and we can review there

@myzhan
Copy link
Contributor

myzhan commented Feb 16, 2019

@cgoldberg please have a look at #962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants