balance/recover the load distribution when new slave joins #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jonnymcc for awareness |
can you move those to a separate PR? |
Jonnymcc
approved these changes
Mar 3, 2019
locust/test/test_zmqrpc.py
Outdated
| self.assertEqual(msg.type, 'test') | ||
| self.assertEqual(msg.data, 'message') | ||
|
|
||
| def test_client_recv(self): | ||
| sleep(0.01) | ||
| sleep(0.1) |
There was a problem hiding this comment.
Was the sleep not long enough?
There was a problem hiding this comment.
no, not long enough at my side, besides there's no harm to set a longer time here.
sure, here is the separate PR: #972 |
|
@cgoldberg please help check this pr and merge into master, let me know if any concern, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Locust master and slave agents running in Kubernetes, Kubernetes will guarantee the availability of Locust agents.
But when a slave agent crashes and restarts, it will have a different client id and it has no idea of the user load that master assigned to it previously. And the total number of running locusts will not be as many as expected.
So it might be a better way to balance the user load when new client joins, and the total number of running locusts will still be the same as we specified in the swarm request.
also this PR fixes some issue I noticed when running in Python 3 with web mode, it turns out to be the inconsistency introduced in recv_from_client and send_to_client
Any thought or comment?