Add command line argument to specify exit code on response errors #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better if the option was truthy... so |
|
I agree, that is a much better way to handle the argument. |
|
this LGTM but I want at least one more person's input on what is "intuitive" before declaring this more intuitive :) |
|
Bump. |
|
@cgoldberg @mbeacom what do you think on this? @Stateford I also renamed the PR so it will show up nicer in the autogenerated release notes. |
aldenpeterson-wf
changed the title
|
👍 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #560. Give an option to disable it. It's probably too late to change the functionality to an opt-in, but exit codes should only post if there's actually a problem with the binary, not because there was an error in a test.