Custom ssl certs option for serve command #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* --ssl-pri and --ssl-pub are the two new commands that were added * These commands allow for custom ssl certs to be passed to weurkzueg run_simple command * --ssl command is still supported and will continue working as it does now. * Updated tests for new ssl flags
|
Thanks, @njaysoftware - good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to resolves #166
I left the current flag
--sslas it is, so it will still create ssl certs 'adhoc'.I added two new flags to the
sls wsgi servecommand. They are--ssl-priand--ssl-pub.These flags take file paths to custom ssl certs that are to be used to serve the app locally over https. The syntax is
--ssl-pri ~/localhost-key.pem --ssl-pub ~/localhost.pem. This will serve the app over https using these ssl certs. The ssl certs can be generated via a tool like mkcertAlso, updated the tests to keep the same code coverage as before.