Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove non-existent validated property from FormMeta types #4784

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jun 20, 2024

🔎 Overview

I noticed that this "property" was undefined, and then realised the docs don't include it so it should be removed from the types.

It looks like the FieldMeta interface has required which doesn't exist either, but I'll do a dedicated PR to remove that

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (926170d) to head (77a507a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4784      +/-   ##
==========================================
- Coverage   89.75%   89.75%   -0.01%     
==========================================
  Files          93       93              
  Lines        7875     7874       -1     
  Branches     1374     1374              
==========================================
- Hits         7068     7067       -1     
  Misses        800      800              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@logaretm logaretm closed this Jun 22, 2024
@logaretm logaretm reopened this Jun 22, 2024
@logaretm
Copy link
Owner

logaretm commented Jun 22, 2024

Sorry I didn't pay attention, yes you are correct. It doesn't exist for the FormMeta, I initially thought this was about the field meta.

Many thanks!

@logaretm logaretm merged commit 8db5b5b into logaretm:main Jun 22, 2024
9 checks passed
@G-Rath G-Rath deleted the patch-1 branch June 22, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants