[HWORKS-927] Support canary serving deployments #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibchikafa
force-pushed
the
HWORKS-927
branch
2 times, most recently
from
793208c
to
03d380c
Compare
gibchikafa
force-pushed
the
HWORKS-927
branch
2 times, most recently
from
1424a37
to
a6455f3
Compare
javierdlrm
requested changes
Jun 24, 2024
| `model_name` varchar(255) COLLATE latin1_general_cs NOT NULL, | ||
| `model_version` int(11) NOT NULL, | ||
| `model_framework` int(11) NOT NULL, | ||
| `deployed` timestamp DEFAULT NULL, |
There was a problem hiding this comment.
deployed field is already in line 1275. No need to add it here.
| `lock_ip` varchar(15) COLLATE latin1_general_cs DEFAULT NULL, | ||
| `lock_timestamp` bigint(20) DEFAULT NULL, | ||
| `serving_tool` int(11) NOT NULL DEFAULT '0', |
There was a problem hiding this comment.
serving_tool is already in line 1274. No need to add it here.
Comment on lines
+1282
to
+1283
| CONSTRAINT unique_specification UNIQUE (specification), | ||
| CONSTRAINT unique_canary_spec UNIQUE (canary_spec), |
There was a problem hiding this comment.
Can you add the missing quotes in the constraint names and the column names?
| @@ -1287,7 +1279,37 @@ CREATE TABLE `serving` ( | |||
| CONSTRAINT `user_fk_serving` FOREIGN KEY (`creator`) REFERENCES `users` (`uid`) ON DELETE CASCADE ON UPDATE NO ACTION, | |||
| CONSTRAINT `deployed_by_fk_serving` FOREIGN KEY (`deployed_by`) REFERENCES `users` (`uid`) ON DELETE CASCADE ON UPDATE NO ACTION, | |||
| CONSTRAINT `kafka_fk` FOREIGN KEY (`kafka_topic_id`) REFERENCES `project_topics` (`id`) ON DELETE SET NULL ON UPDATE NO ACTION, | |||
| CONSTRAINT `FK_284_315` FOREIGN KEY (`project_id`) REFERENCES `project` (`id`) ON DELETE CASCADE ON UPDATE NO ACTION | |||
There was a problem hiding this comment.
Why is this constraint removed?
| `serving_tool` int(11) NOT NULL DEFAULT '0', | ||
| `specification` int(11) NOT NULL, | ||
| `canary_spec` int(11) DEFAULT NULL, | ||
| `canary_traffic_percentage` TINYINT DEFAULT NULL, | ||
| `kafka_topic_id` int(11) DEFAULT NULL, | ||
| `inference_logging` int(11) DEFAULT NULL, | ||
| `model_server` int(11) NOT NULL DEFAULT '0', |
There was a problem hiding this comment.
model_server is on the serving_spec table. We should remove it from here.
| `serving_tool` int(11) NOT NULL DEFAULT '0', | ||
| `specification` int(11) NOT NULL, | ||
| `canary_spec` int(11) DEFAULT NULL, | ||
| `canary_traffic_percentage` TINYINT DEFAULT NULL, | ||
| `kafka_topic_id` int(11) DEFAULT NULL, | ||
| `inference_logging` int(11) DEFAULT NULL, | ||
| `model_server` int(11) NOT NULL DEFAULT '0', | ||
| `serving_tool` int(11) NOT NULL DEFAULT '0', | ||
| `deployed` timestamp DEFAULT NULL, | ||
| `deployed_by` int(11) DEFAULT NULL, | ||
| `revision` varchar(8) DEFAULT NULL, |
There was a problem hiding this comment.
revision is on the serving_spec table. We should remove it from here also
| @@ -45,3 +45,49 @@ ALTER TABLE `hopsworks`.`feature_store_jdbc_connector` | |||
| ALTER TABLE `hopsworks`.`serving` ADD COLUMN `deployed_by` int(11) DEFAULT NULL; | |||
| ALTER TABLE `hopsworks`.`serving` ADD KEY `deployed_by_fk` (`deployed_by`); | |||
| ALTER TABLE `hopsworks`.`serving` ADD CONSTRAINT `deployed_by_fk_serving` FOREIGN KEY (`deployed_by`) REFERENCES `users` (`uid`) ON DELETE CASCADE ON UPDATE NO ACTION; | |||
|
|
|||
| -- HWORKS-927 | |||
| ALTER TABLE `hopsworks`.`serving` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.