(Fixed) IR Additions

[emptythevoid]

The only thing I would like to ignore with the linter, if possible, is for the GPX_D2816.ir file. The remote actually has printed "Prev" and "Next." I can change them, if you'd prefer, but I thought I'd explain first.

Otherwise, I think everything else is fixed.

[github-actions]

🐛 Linter Result

DVD_Players/GPX/GPX_D2816.ir [2 issues]

# Line 278:
- name: Prev
        ^^^^
@@ ambiguous name 'Prev' @@

# Line 284:
- name: Next
        ^^^^
@@ ambiguous name 'Next' @@

---

[darmiel]

Thank you for your additions and for fixing the previous issues 🙂

The linter only complains about the names because they occur twice (2x Prev, 2x Next), which can lead to confusion.
Is it possible that the duplicates are Fast Forward/Backward ? On a picture of the remote I saw the following buttons:

But if you say it's correct as it is now, that's okay too and I can go ahead and merge it as it currently is.

P.S. you don't need to close and create a new pull request when you update something. Just push the changes to the branch you created the PR from (in your case iradditions) and the pull request will automatically update too 🙂

[emptythevoid]

I can't do a good job explaining, except I think I tried to fix it from the linter, decided against it, and un-fixed the wrong thing. Does it look OK now?

[emptythevoid]

(And thank you for helping me. I'm not used to using a proper github workflow with others)

Outdated

[darmiel]

Yes, looks good now 👍

[emptythevoid]

Thank you very much!