Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dot notation support #73

Merged
merged 5 commits into from
Sep 11, 2019

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Sep 11, 2019

builds on top of #71 and replaces #70

fixes #50

Copy link
Contributor

@colinsurprenant colinsurprenant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinsurprenant
Copy link
Contributor

Reminder to bump version. Patch versions seems right here since this is BWC bugfix.

CHANGELOG.md Outdated Show resolved Hide resolved
@colinsurprenant
Copy link
Contributor

Minor cosmetic comment. LGTM²

Co-Authored-By: Colin Surprenant <[email protected]>
@jsvd jsvd merged commit efd3e89 into logstash-plugins:master Sep 11, 2019
@jsvd jsvd deleted the improve_dot_notation_support branch September 11, 2019 17:48
@colinsurprenant
Copy link
Contributor

v6.0.1 published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

additional keys following name.sub where sub is 2 characters being missed
3 participants