-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue #62 - Changed agentHost field name to match CEF docs #75
Conversation
This commit fixes issue logstash-plugins#62. According to CEF documentation, the short name 'ahost' corresponds to 'agentHostName' and not 'agentHost' as it's being used now.
Thanks Ricardo, this seems correct. |
There should have been a failing spec with this change ... around CI did not run here so we're not seeing the 🔴 here, could you please look at those? |
actually CI did run: https://travis-ci.org/logstash-plugins/logstash-codec-cef/builds/612443494 |
1 similar comment
…issue logstash-plugins#62. Initial commit was missing this part.
Hi @kares , |
|
did not see #45 ... should review the field updates, later. in terms of version lets do 6.1 (definitely not patch but inc minor) |
@n3g would you be able to add a version bump + changelog commit? |
@kares, @colinsurprenant: should I bump to 6.1.0 then? Current one is 6.0.1. |
@n3g yes, bump to 6.1.0 and add to the |
There seems to be an error in the tests, but it's not related to the change. Any idea how to rerun this? |
@n3g restarted the build. LGTM pending green. |
v6.1.0 published! |
This commit fixes issue #62.
According to CEF documentation, the short name 'ahost' corresponds to 'agentHostName' and not 'agentHost' as it's being used now.
Note: this might have impact on code already using the incorrect mapping.