Improve encoding performance #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
reviewed
Apr 6, 2020
yaauie
force-pushed
the
encode-performance
branch
from
56f7d6a
to
6e37f4c
Compare
|
@colinsurprenant can you take one more look? I refactored since your LGTM to get even better performance. |
| value = value.to_s.gsub(/[^a-zA-Z0-9]/, "") | ||
| return value | ||
| value.to_s | ||
| .gsub(/[^a-zA-Z0-9]/, "") |
There was a problem hiding this comment.
cosmetic: newline might not be necessary here.
|
LGTM² |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change-set replaces character-by-character input sanitizers with equivalent gsub expressions, improving performance especially when many fields are referenced.
For example, when used with the TCP Output and simple field values, I was able to achieve the following maximum throughputs on a 16-worker pipeline: