ECS Compatibility Docs, minor fixes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenzone
reviewed
Apr 20, 2021
There was a problem hiding this comment.
Multi-column tables don't always render well, and this one needs some help. Let's discuss some different approaches. Moving notes under ECS field column, for example. Something like this treatment: https://www.elastic.co/guide/en/ecs/current/ecs-host.html
Content on or around line 336 is a duplicate, likely a result of a suggestion in github review.
yaauie
force-pushed
the
ecs-compatibility-docs
branch
from
55674d8
to
4c89d29
Compare
karenzone
reviewed
Apr 23, 2021
Co-authored-by: Karen Metts <[email protected]>
karenzone
reviewed
Apr 23, 2021
Co-authored-by: Karen Metts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deviceMacAddressfield when in ECS mode; now correctly resolves to either[host][mac]or[observer][mac]based on the value of thedeviceoption, instead of the literal[@device][mac].