-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/remove dependencies #393
Conversation
In addition to the integration tests, this commit was tested against this script created by @jsvd to exercise this issue where the IdleStateHandler was holding back acknowledgements. Running this script to completion: Beats Input
This commit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
please bump, squash and 🚢
@jsvd - one thing to note, this will break on versions of Java 8 without the JCE Unlimited Strength Jurisdiction Policy installed. From I can update the plugin to be more lenient, and warn on missing ciphers, and only fail when no ciphers are available. WDYT? |
I think it's fine that we detect if jce isn't available (maybe through the maximum cipher lenght which should be 128 w/o jce), we exclude the aes 256 ciphers:
|
This commit updates the following dependencies: Jackson-databind to `2.9.10.4` Netty to `4.1.49.final` Additionally, this commit removes the dependency on `tcnative` + `boringssl` from logstash-plugins#384, which enables the update of netty dependencies while still allowing logstash->logstash communication via the lumberjack output plugin. (`boringssl` removed compatibility with `CBC` ciphers, which are still a prerequisite for lumberjack output plugin support at this time,
While it is been the default for Java since JDK 8u161 released in early 2018, old versions of Java may not have the JCE unlimited strength jurisdiction policy installed. This commit handles this case, warning the user that the policy is not installed, and presenting a reduced set of default ciphers for use.
@jsvd I've made the changes and updated the changelog and bumped the version - do you think the version should be a minor or patch update? |
I'd vote on patch as a it's a fix and doesn't introduce any new user facing capability |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit updates the following dependencies:
Jackson-databind to
2.9.10.4
Netty to
4.1.49.final
Additionally, this commit removes the dependency on
tcnative
+boringssl
based on the work done by @jsvd in #384, which enables the update of netty dependencies while still allowing logstash->logstash communication via the lumberjackoutput plugin. (
boringssl
removed compatibility withCBC
ciphers, whichare still a prerequisite for lumberjack output plugin support at this time)