Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Move ECS table to the Initial section #413

Merged
merged 4 commits into from
Mar 30, 2021

Conversation

roaksoax
Copy link
Contributor

Moves the ECS mapping table to the initial section that describes event metadata and the event.

Moves the ECS mapping table to the initial section that describes event metadata and the event.
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the mapping info grouped with the higher level conceptual info. I suggested a minor change to the sentence before the table for your consideration.

Otherwise, builds cleanly and LGTM.

docs/index.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/index.asciidoc Outdated Show resolved Hide resolved
@karenzone
Copy link
Contributor

Here's how it looks:
Screen Shot 2021-03-30 at 12 59 34 PM

I liked the back ticks, even though they weren't rendering. They provided a visual indication that "disabled" and "v1" were config options. If everybody else prefers it this way, I'll live with it. :-) LGTM

@roaksoax roaksoax merged commit 42cdfba into master Mar 30, 2021
@karenzone karenzone mentioned this pull request Mar 30, 2021
karenzone added a commit that referenced this pull request Mar 30, 2021
Bump version to publish doc changes in #413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants