Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: do not package log4j-api dependency #441

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Build: do not package log4j-api dependency #441

merged 2 commits into from
Jan 4, 2022

Conversation

kares
Copy link
Contributor

@kares kares commented Dec 30, 2021 •
edited
Loading 

diff --git lib/logstash-input-beats_jars.rb lib/logstash-input-beats_jars.rb
index f70dd30..5a9ab56 100644
--- lib/logstash-input-beats_jars.rb
+++ lib/logstash-input-beats_jars.rb
@@ -7,5 +7,4 @@ require_jar('com.fasterxml.jackson.core', 'jackson-core', '2.9.10')
 require_jar('com.fasterxml.jackson.core', 'jackson-annotations', '2.9.10')
 require_jar('com.fasterxml.jackson.core', 'jackson-databind', '2.9.10.8')
 require_jar('com.fasterxml.jackson.module', 'jackson-module-afterburner', '2.9.10')
-require_jar('org.apache.logging.log4j', 'log4j-api', '2.17.0')
 require_jar('org.logstash.beats', 'logstash-input-beats', '6.2.4')

@kares kares marked this pull request as ready for review December 30, 2021 08:23
@kares kares marked this pull request as draft December 30, 2021 14:12
@kares kares marked this pull request as ready for review January 3, 2022 09:12
andsel
andsel approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kares kares merged commit 961d622 into logstash-plugins:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andsel andsel andsel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kares @andsel @roaksoax