Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove LSF from integration testing and core references (#481)" #486

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

roaksoax
Copy link
Contributor

@roaksoax roaksoax commented Nov 20, 2023

This reverts commit 045626b.

Restores accidentally removed source pieces. The case where events from Lumberjack come with line field is broken now and this PR restores the feature. We will address removing LSF integration tests with separate PR.

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mashhurs mashhurs merged commit a6cdac9 into logstash-plugins:main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants