-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs a warn message on max order overshoot #493
Merged
andsel
merged 8 commits into
logstash-plugins:main
from
andsel:feature/log_warn_on_max_order_overshoot
Feb 22, 2024
Merged
Logs a warn message on max order overshoot #493
andsel
merged 8 commits into
logstash-plugins:main
from
andsel:feature/log_warn_on_max_order_overshoot
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verruns the actual maxOrder and trigger an unpooled allocation
…ded test case to avoid notify a maxOrder minor than last max order notified
andsel
changed the title
Feature/log warn on max order overshoot
Logs a warn message on max order overshoot
Feb 14, 2024
jsvd
reviewed
Feb 22, 2024
Co-authored-by: João Duarte <[email protected]>
jsvd
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Added logging the best Netty's
maxOrder
setting when big payload trigger an unpooled allocationWhat does this PR do?
Print a log line with the preferred Netty's
maxOrder
to accomodate the buffer size that exceeds the actual chunk size that would trigger an unpooled allocation.It prints the log just one time across all plugin instances for each maxOrder required. So if plugin instance A reaches the limit of 4Mb (aka maxOrder 9) with a desired payload size of 7Mb it will report line about to use maxOrder 10. After this log line is printed, any other plugin instance wouldn't report it again, unless it needs an even bigger maxOrder not yet reported.
This PR also introduces a test spy of the Logger class to test the behaviour.
Why is it important/What is the impact to the user?
Helps the user to set the right
maxOrder
for his message flow to avoid slow unpooled allocation.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
n
doesn't print either notification for< n
How to test this PR locally
It needs the test tool present in branch
ingest_all_hands_ams
contained in PR elastic/logstash#15151../gradlew vendor
)config/(log4j2.properties
) add:ingest_all_hands_ams
run:maxOrder
of 10, like:Related issues
Use cases
Screenshots
Logs