Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor shutdown sequence to use plugin.stop #17

Closed
jsvd opened this issue Sep 11, 2015 · 1 comment
Closed

refactor shutdown sequence to use plugin.stop #17

jsvd opened this issue Sep 11, 2015 · 1 comment
Assignees
@ph
Labels
shutdown semantics

Comments

@jsvd
Copy link
Member

jsvd commented Sep 11, 2015

Change shutdown sequence to be triggered by plugin.stop instead of ShutdownSignal exception.
Also remove any calls to: shutdown, finished, finished?, running? or terminating?
This depends on elastic/logstash#3895
@jsvd jsvd mentioned this issue Sep 11, 2015
Closed
43 tasks
@ph ph assigned ph and unassigned colinsurprenant Sep 17, 2015
@ph
Copy link
Contributor

ph commented Sep 17, 2015

I am taking it @colinsurprenant

ph added a commit to ph/logstash-input-gelf that referenced this issue Sep 17, 2015
@ph
Refactor the shutdown
cbe1d58 
This PR introduces the changes needed to follow the new shutdown
semantic, it also remove the gelf as a runtime dependencies and move it
as a development dependency since its only used in the tests.

Fixes logstash-plugins#17
ph added a commit to ph/logstash-input-gelf that referenced this issue Sep 17, 2015
@ph
Refactor the shutdown
45aff7e 
This PR introduces the changes needed to follow the new shutdown
semantic, it also remove the gelf as a runtime dependencies and move it
as a development dependency since its only used in the tests.

Fixes logstash-plugins#17
@ph ph mentioned this issue Sep 17, 2015
Closed
ph added a commit to ph/logstash-input-gelf that referenced this issue Sep 21, 2015
@ph
Refactor the shutdown
134965d 
This PR introduces the changes needed to follow the new shutdown
semantic, it also remove the gelf as a runtime dependencies and move it
as a development dependency since its only used in the tests.

Fixes logstash-plugins#17
@ph ph closed this as completed in 1b3efd7 Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ph ph

Labels
shutdown semantics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ph @colinsurprenant @jsvd