refactor shutdown sequence to use plugin.stop

[jsvd]

Change shutdown sequence to be triggered by plugin.stop instead of ShutdownSignal exception.
Also remove any calls to: shutdown, finished, finished?, running? or terminating?
This depends on elastic/logstash#3895

[russorat]

@jsvd if i understand the linked ticket correctly, since this plugin doesn't have a shutdown function and does not catch any ShutdownSignal exceptions, there really isn't anything to refactor? Am i missing something?

[jsvd]

bad side of leaving as it is, is that if the query + data processing takes a while, logstash won't exit until the task is finished.

So you can decide, for example, that the plugin should check if it's time to shutdown after processing each event from the query, and abort if so. You can do this by placing a return if stop? after pushing an event to the queue, for example. Obviously this means that whatever system you're sending data to will have partial data.

[russorat]

good points. i will update.

On Thu, Sep 24, 2015 at 2:43 PM, João Duarte [email protected]
wrote:

bad side of leaving as it is, is that if the query + data processing takes
a while, logstash won't exit until the task is finished.

So you can decide, for example, that the plugin should check if it's time
to shutdown after processing each event from the query, and abort if so.
You can do this by placing a return if stop? after pushing an event to
the queue, for example. Obviously this means that whatever system you're
sending data to will have partial data.

—
Reply to this email directly or view it on GitHub
#3 (comment)
.