Updates storage path for internal data to use subfolder in Logstash's data.path
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
changed the title
yaauie
reviewed
Mar 4, 2022
yaauie
previously requested changes
Mar 10, 2022
|
The failure on |
andsel
changed the title
data.path
andsel
force-pushed
the
fix/use_data_dir_to_store_last_run_file
branch
from
6cff405
to
f210543
Compare
yaauie
reviewed
Mar 23, 2022
|
The 🔴 CI is due to a |
roaksoax
dismissed
yaauie’s stale review
All changes have been implemented, requesting re-review.
yaauie
requested changes
Apr 27, 2022
andsel
force-pushed
the
fix/use_data_dir_to_store_last_run_file
branch
from
4f72e4e
to
77f9c18
Compare
|
@yaauie the PR is ready for another round of review :-) |
…S data.path folder and not in /home/andrea
…e new destination
Copy the old file to new location, if not yet created, and then tries to delete the old one.
Co-authored-by: Ry Biesemeyer <[email protected]>
Co-authored-by: Ry Biesemeyer <[email protected]>
…h.data}/plugins/shared/derby_home
andsel
force-pushed
the
fix/use_data_dir_to_store_last_run_file
branch
from
77f9c18
to
bf964f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Change default path of 'last_run_metadata_path' to be rooted in the LS
data.pathfolder and not in $HOME. Also apply a path forward action to move existing metadata file to the new destination.What does this PR do?
Change default path of 'last_run_metadata_path' to be rooted in the LS data.path folder and not in $HOME, in the input plugin.
Provide a path forward for existing metada file in
$HOMEto be moved in the newdata.pathdestination.Updates the path used by derby inside the jdbc_static filter plugin to use Logstash
data.pathsubfolder.Why is it important/What is the impact to the user?
It avoid to store state data into path that Logstash process doesn't have the rights to access.
After PR elastic/logstash#12782, released with Logstash
7.13.0, the owner of Logstash installation dir changed fromlogstashuser toroot, so the $HOME directory used by Logstash process is not writable by it.The process must store data only in the
data.pathfolder.There's the expectation to create the smoothest path forward, so that users doesn't need to manually update their pipelines nor to manually intervene in moving files on their machines.
Checklist
[] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Related issues
Use cases
As a user that uses the
record_last_runI want to be able to upgrade to Logstash >= 7.13 without any throubles about access rights on internal storage files.