Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: driver loading when file not accessible #15

Merged
merged 3 commits into from
Jan 22, 2020

Conversation

kares
Copy link
Contributor

@kares kares commented Jan 21, 2020

these are non-critical improvements for (input) driver loading.

issues are kept on the original repo since they concern the plugin.
this is expected to resolve logstash-plugins/logstash-input-jdbc#369
(also partially relates to logstash-plugins/logstash-input-jdbc#362)

not sure these are worth "back-port"-ing, in any case there's a draft

@kares kares requested a review from robbavey January 21, 2020 15:55
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

LGTM

@kares kares merged commit a7e12df into logstash-plugins:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better handling for invalid driver paths
2 participants