driver loading: provide loaded driver to Sequel::connect #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
force-pushed
the
improved-driver-loading
branch
2 times, most recently
from
14049f6
to
e12b7d0
Compare
|
@robbavey I've gone back and added the driver fallback logic to all three plugins, and adjusted their specs to ensure that the result of |
robbavey
approved these changes
Jun 10, 2020
`Sequel::connect` will first attempt to auto-detect the driver based on the jdbc connection string, and will [fall-back][] to the driver given as opts[:driver] when auto-detection fails. By memoizing the loaded driver from our previous `Sequel::JDBC::load_driver` and providing it to `Sequel::connect`, we provide one more chance for loading to work. This specifically seems to be the only path forward for Sybase drivers, whose jdbc connection strings begin with `jdbc:sybase:Tds:` but use the driver with path `com.sybase.jdbc4.jdbc.SybDriver`. [fall-back]: https://github.com/jeremyevans/sequel/blob/5.19.0/lib/sequel/adapters/jdbc.rb#L211-L213 Fixes: logstash-plugins#23 Fixes: logstash-plugins#30
yaauie
force-pushed
the
improved-driver-loading
branch
from
e12b7d0
to
e5dff35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel::connectwill first attempt to auto-detect the driver based on thejdbc connection URI, and will fall-back to the driver given as
opts[:driver]when auto-detection fails.
By memoizing the loaded driver from our previous
Sequel::JDBC::load_driverand providing it to
Sequel::connect, we provide one more chance for loadingto work.
This specifically seems to be the only path forward for Sybase drivers, whose
jdbc connection strings begin with
jdbc:sybase:Tds:but use the driver withpath
com.sybase.jdbc4.jdbc.SybDriver.