Fix: properly pass (symbolized) sequel opts #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of the jdbc input
sequel_opts => ...
were being passed with string keys (the streaming plugin symbolizes keys).this is fine e.g. for passing
sequel_opts => { "jdbc_properties" => { ... } }
as sequel handles the"jdbc_properties"
case but officially it's documented as:jdbc_properties
.string keys turned out problematic when trying to disable quoting using:
sequel_opts => { quote_identifiers => false }
the option wasn't being picked from the Hash, as Sequel only checks for:quote_identifiers
key.also took this opportunity to introduce some sharing between jdbc and jdbc_streaming plugins as I noticed some of the previously fixed issues (e.g. driver loading) could also affect the (lesser used) jdbc_streaming plugin.