Extracted template method for static filter #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In class LogStash::Filters::Jdbc::Lookup the methods fetch(local, event), call_prepared(local, event) shared a lot of logic. Extracted common part in template method name 'retrieve_local_data(local, event, load_method_ref)' and separated the differiation logic in methods: - load_data_from_prepared, used to load data from prepared statement rows - load_data_from_local, used to load data from normal statement rows
andsel
force-pushed
the
fix/extracted_common_code_in_template_method
branch
from
b59dad2
to
7f05acf
Compare
kares
reviewed
Mar 8, 2021
lib/logstash/filters/jdbc/lookup.rb
Outdated
Comment on lines
84
to
88
| if @prepared_statement | ||
| result = call_prepared(local, event) | ||
| load_method_ref = method(:load_data_from_prepared) | ||
| else | ||
| result = fetch(local, event) # should return a LookupResult | ||
| load_method_ref = method(:load_data_from_local) | ||
| end |
There was a problem hiding this comment.
could we move this whole block to happen during LookupProcessor#initialize?
enhance is called on plugin.filter so we end up doing the method lookup every time.
we should be able to keep the looked up method in an instance field as @prepared_statement is known ahead.
There was a problem hiding this comment.
Thanks @kares to have pointed it out, now the Lookup.initialize sets by default to load_data_from_local but when the method Lookup.prepare is called we switch to load_data_from_prepared, so essentially we removed the "if"
…a eager way, when the Lookup is configured, so avoid the method selection for every event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In class LogStash::Filters::Jdbc::Lookup the methods fetch(local, event), call_prepared(local, event) shared a lot of logic.
Extracted common part in template method name 'retrieve_local_data(local, event, load_method_ref)' and separated
the differiation logic in methods:
load_data_from_prepared, used to load data from prepared statement rowsload_data_from_local, used to load data from normal statement rowsFixes #60