Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prepared_statement_bind_values to resolve nested event's fields #76

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Jun 23, 2021

JDBC streaming filter uses the setting prepared_statement_bind_values to bind event's fields or constants to SQL prepared statements. It resolves fields with the notation [field_name] but it's not able to match the nested form: [field][nested], this PR changes the match regexp to fix it.

Fixes #75

@andsel andsel changed the title Added spec to verify extract_from with nested field Fix prepared_statement_bind_values to resolve nested event's fields Jun 23, 2021
@andsel andsel marked this pull request as ready for review June 23, 2021 16:07
@andsel andsel requested a review from jsvd June 23, 2021 16:09
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for taking care of this issue @andsel ❤️

@andsel andsel merged commit f1bf6ae into logstash-plugins:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prepared_statement_bind_values in jdbc_streaming doesn't handle nested fields
3 participants