Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS: refinements #82

Merged
merged 3 commits into from
Aug 4, 2021
Merged

ECS: refinements #82

merged 3 commits into from
Aug 4, 2021

Conversation

yaauie
Copy link
Contributor

@yaauie yaauie commented Jul 28, 2021

  • use shared Target Check
  • use EventFactory to create events

kares
kares approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@kares kares left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍦 - should be the last tier 1 with missing event_factory support

could use a changelog but otherwise lgtm!

@yaauie yaauie merged commit 6e26bc5 into logstash-plugins:master Aug 4, 2021
@yaauie yaauie deleted the ecs-shared-target-check branch August 4, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kares kares kares approved these changes

Assignees
No one assigned
Labels
status:approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaauie @kares @roaksoax