Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add GET /configs/jwt-customizer API #5465

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Mar 4, 2024

Summary

Add GET /configs/jwt-customizer/:tokenType API

Testing

Covered by unit test and integration tests.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions github-actions bot added the feature Cool stuff label Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

COMPARE TO master

Total Size Diff 📈 +3.62 KB

Diff by File
Name Diff
packages/core/src/libraries/cloud-connection.test.ts 📈 +31 Bytes
packages/core/src/libraries/logto-config.ts 📈 +638 Bytes
packages/core/src/libraries/sign-in-experience/index.test.ts 📈 +31 Bytes
packages/core/src/queries/logto-config.ts 📈 +509 Bytes
packages/core/src/routes/logto-config.openapi.json 📈 +546 Bytes
packages/core/src/routes/logto-config.test.ts 📈 +412 Bytes
packages/core/src/routes/logto-config.ts 📈 +660 Bytes
packages/integration-tests/src/api/logto-config.ts 📈 +234 Bytes
packages/integration-tests/src/tests/api/logto-config.test.ts 📈 +647 Bytes

@github-actions github-actions bot added the size/s label Mar 4, 2024
@darcyYe darcyYe force-pushed the yemq-log-8283-add-GET-configs-jwt-customizer-API branch from df8bc28 to 09f6959 Compare March 4, 2024 08:02
@darcyYe darcyYe force-pushed the yemq-log-8282-add-POST-configs-jwt-customizer-API branch 2 times, most recently from c14c646 to 4b3aa2a Compare March 4, 2024 08:21
@darcyYe darcyYe force-pushed the yemq-log-8283-add-GET-configs-jwt-customizer-API branch from 09f6959 to 858364e Compare March 4, 2024 08:41
@github-actions github-actions bot added size/xl and removed size/s labels Mar 4, 2024
@darcyYe darcyYe force-pushed the yemq-log-8283-add-GET-configs-jwt-customizer-API branch from 858364e to 8086c9b Compare March 4, 2024 08:42
@github-actions github-actions bot added size/s and removed size/xl labels Mar 4, 2024
@darcyYe darcyYe force-pushed the yemq-log-8282-add-POST-configs-jwt-customizer-API branch 2 times, most recently from e9cad8f to be518dc Compare March 5, 2024 16:22
@darcyYe darcyYe force-pushed the yemq-log-8283-add-GET-configs-jwt-customizer-API branch 2 times, most recently from 02aa9cd to 6847e84 Compare March 6, 2024 05:10
@github-actions github-actions bot added size/m and removed size/s labels Mar 6, 2024
@darcyYe darcyYe force-pushed the yemq-log-8283-add-GET-configs-jwt-customizer-API branch from 296cf23 to 31c36c4 Compare March 6, 2024 10:22
@darcyYe darcyYe force-pushed the yemq-log-8283-add-GET-configs-jwt-customizer-API branch from 31c36c4 to e327754 Compare March 6, 2024 11:33
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

Base automatically changed from yemq-log-8282-add-POST-configs-jwt-customizer-API to master March 7, 2024 06:10
@darcyYe darcyYe merged commit ce2abe7 into master Mar 7, 2024
18 checks passed
@darcyYe darcyYe deleted the yemq-log-8283-add-GET-configs-jwt-customizer-API branch March 7, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants