-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add GET /configs/jwt-customizer API #5465
Merged
darcyYe
merged 4 commits into
master
from
yemq-log-8283-add-GET-configs-jwt-customizer-API
Mar 7, 2024
Merged
feat(core): add GET /configs/jwt-customizer API #5465
darcyYe
merged 4 commits into
master
from
yemq-log-8283-add-GET-configs-jwt-customizer-API
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
Name | Diff |
---|---|
packages/core/src/libraries/cloud-connection.test.ts | 📈 +31 Bytes |
packages/core/src/libraries/logto-config.ts | 📈 +638 Bytes |
packages/core/src/libraries/sign-in-experience/index.test.ts | 📈 +31 Bytes |
packages/core/src/queries/logto-config.ts | 📈 +509 Bytes |
packages/core/src/routes/logto-config.openapi.json | 📈 +546 Bytes |
packages/core/src/routes/logto-config.test.ts | 📈 +412 Bytes |
packages/core/src/routes/logto-config.ts | 📈 +660 Bytes |
packages/integration-tests/src/api/logto-config.ts | 📈 +234 Bytes |
packages/integration-tests/src/tests/api/logto-config.test.ts | 📈 +647 Bytes |
darcyYe
force-pushed
the
yemq-log-8283-add-GET-configs-jwt-customizer-API
branch
from
March 4, 2024 08:02
df8bc28
to
09f6959
Compare
darcyYe
force-pushed
the
yemq-log-8282-add-POST-configs-jwt-customizer-API
branch
2 times, most recently
from
March 4, 2024 08:21
c14c646
to
4b3aa2a
Compare
darcyYe
force-pushed
the
yemq-log-8283-add-GET-configs-jwt-customizer-API
branch
from
March 4, 2024 08:41
09f6959
to
858364e
Compare
darcyYe
force-pushed
the
yemq-log-8283-add-GET-configs-jwt-customizer-API
branch
from
March 4, 2024 08:42
858364e
to
8086c9b
Compare
simeng-li
reviewed
Mar 5, 2024
darcyYe
force-pushed
the
yemq-log-8282-add-POST-configs-jwt-customizer-API
branch
2 times, most recently
from
March 5, 2024 16:22
e9cad8f
to
be518dc
Compare
darcyYe
force-pushed
the
yemq-log-8283-add-GET-configs-jwt-customizer-API
branch
2 times, most recently
from
March 6, 2024 05:10
02aa9cd
to
6847e84
Compare
simeng-li
reviewed
Mar 6, 2024
darcyYe
force-pushed
the
yemq-log-8283-add-GET-configs-jwt-customizer-API
branch
from
March 6, 2024 10:22
296cf23
to
31c36c4
Compare
darcyYe
force-pushed
the
yemq-log-8283-add-GET-configs-jwt-customizer-API
branch
from
March 6, 2024 11:33
31c36c4
to
e327754
Compare
simeng-li
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
Base automatically changed from
yemq-log-8282-add-POST-configs-jwt-customizer-API
to
master
March 7, 2024 06:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
GET /configs/jwt-customizer/:tokenType
APITesting
Covered by unit test and integration tests.
Checklist
.changeset