-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add DELETE /configs/jwt-customizer API #5467
feat(core): add DELETE /configs/jwt-customizer API #5467
Conversation
COMPARE TO
|
Name | Diff |
---|---|
packages/core/src/queries/logto-config.ts | 📈 +53 Bytes |
packages/core/src/routes/logto-config.openapi.json | 📈 +588 Bytes |
packages/core/src/routes/logto-config.test.ts | 📈 +389 Bytes |
packages/core/src/routes/logto-config.ts | 📈 +584 Bytes |
packages/integration-tests/src/api/logto-config.ts | 📈 +164 Bytes |
packages/integration-tests/src/tests/api/logto-config.test.ts | 📈 +701 Bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
02aa9cd
to
6847e84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set the token to nullable, then there is no need for "post" and "delete", just "put", if the user want to delete, he can pass { "token": null }
to "put" payload
31c36c4
to
e327754
Compare
3540633
to
29d7642
Compare
The whole JWT-customization-related data is stored as a record in our |
Summary
Add
DELETE /configs/jwt-customizer/:tokenType
APITesting
Covered by unit tests and integration tests.
Checklist
.changeset