Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove slonik from shared #5512

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Mar 15, 2024

Summary

(please ignore the branch name)

  • remove slonik from @logto/shared to make that package as clean as possible. the current version ^30.0.0 uses zod as a dependency which makes the size too large.
  • lock slonik version

it's good for functions (they need to use @logto/shared)

Testing

no function change, so ci

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Mar 15, 2024

COMPARE TO master

Total Size Diff 📈 +3.47 KB

Diff by File
Name Diff
packages/cli/package.json 📈 +1 Bytes
packages/cli/src/commands/database/seed/tables.ts 📈 +34 Bytes
packages/cli/src/database.ts 📈 +5 Bytes
packages/cli/src/queries/logto-config.ts 📈 +3 Bytes
packages/cli/src/queries/system.test.ts 📈 +4 Bytes
packages/cli/src/queries/system.ts 📈 +3 Bytes
packages/cli/src/sql.ts 📈 +2.5 KB
packages/core/package.json 📈 +1 Bytes
packages/core/src/database/find-all-entities.ts 📈 +5 Bytes
packages/core/src/database/find-entity-by-id.ts 📈 +4 Bytes
packages/core/src/database/insert-into.test.ts 📈 +4 Bytes
packages/core/src/database/insert-into.ts 📈 +26 Bytes
packages/core/src/database/update-where.ts 📈 +4 Bytes
packages/core/src/database/utils.ts 📈 +37 Bytes
packages/core/src/errors/SlonikError/index.ts 📈 +42 Bytes
packages/core/src/libraries/logto-config.ts 📈 +4 Bytes
packages/core/src/libraries/user.ts 📈 +4 Bytes
packages/core/src/middleware/koa-auth/utils.ts 📈 +4 Bytes
packages/core/src/queries/application-sign-in-experience.ts 📈 +4 Bytes
packages/core/src/queries/application-user-consent-organizations.ts 📈 +4 Bytes
packages/core/src/queries/application-user-consent-scopes.ts 📈 +4 Bytes
packages/core/src/queries/application.test.ts 📈 +11 Bytes
packages/core/src/queries/application.ts 📈 +8 Bytes
packages/core/src/queries/applications-roles.ts 📈 +4 Bytes
packages/core/src/queries/connector.test.ts 📈 +4 Bytes
packages/core/src/queries/connector.ts 📈 +4 Bytes
packages/core/src/queries/custom-phrase.ts 📈 +36 Bytes
packages/core/src/queries/daily-active-user.ts 📈 +4 Bytes
packages/core/src/queries/daily-token-usage.ts 📈 +36 Bytes
packages/core/src/queries/domains.ts 📈 +28 Bytes
packages/core/src/queries/hooks.ts 📈 +4 Bytes
packages/core/src/queries/log.ts 📈 +4 Bytes
packages/core/src/queries/logto-config.test.ts 📈 +4 Bytes
packages/core/src/queries/logto-config.ts 📈 +4 Bytes
packages/core/src/queries/oidc-model-instance.test.ts 📈 +4 Bytes
packages/core/src/queries/oidc-model-instance.ts 📈 +4 Bytes
packages/core/src/queries/organization/index.ts 📈 +4 Bytes
packages/core/src/queries/organization/relations.ts 📈 +4 Bytes
packages/core/src/queries/passcode.test.ts 📈 +11 Bytes
packages/core/src/queries/passcode.ts 📈 +4 Bytes
packages/core/src/queries/resource.test.ts 📈 +4 Bytes
packages/core/src/queries/resource.ts 📈 +8 Bytes
packages/core/src/queries/roles-scopes.ts 📈 +4 Bytes
packages/core/src/queries/roles.test.ts 📈 +11 Bytes
packages/core/src/queries/roles.ts 📈 +8 Bytes
packages/core/src/queries/scope.ts 📈 +8 Bytes
packages/core/src/queries/sso-connectors.ts 📈 +4 Bytes
packages/core/src/queries/system.ts 📈 +5 Bytes
packages/core/src/queries/tenant.ts 📈 +5 Bytes
packages/core/src/queries/user-sso-identities.ts 📈 +4 Bytes
packages/core/src/queries/user.test.ts 📈 +4 Bytes
packages/core/src/queries/user.ts 📈 +8 Bytes
packages/core/src/queries/users-roles.ts 📈 +4 Bytes
packages/core/src/queries/verification-status.ts 📈 +4 Bytes
packages/core/src/routes/interaction/actions/helpers.ts 📈 +4 Bytes
packages/core/src/sentinel/basic-sentinel.ts 📈 +36 Bytes
packages/core/src/utils/RelationQueries.ts 📈 +28 Bytes
packages/core/src/utils/SchemaQueries.ts 📈 +28 Bytes
packages/core/src/utils/sql.test.ts 📈 +3.75 KB
packages/core/src/utils/sql.ts 📈 +3.31 KB
packages/schemas/package.json 📈 +1 Bytes
packages/shared/package.json 📈 +25 Bytes
packages/shared/src/database/sql.test.ts 📈 +3.75 KB
packages/shared/src/database/sql.ts 📈 +3.19 KB
packages/shared/src/database/types.ts 📈 +143 Bytes
packages/shared/src/index.ts 📈 +35 Bytes
pnpm-lock.yaml 📈 +657 Bytes

@github-actions github-actions bot added size/l and removed size/m labels Mar 16, 2024
@gao-sun gao-sun force-pushed the gao-shared-default-universal branch from b742ae9 to 54c2b1d Compare March 16, 2024 06:46
@gao-sun gao-sun marked this pull request as ready for review March 16, 2024 06:46
@gao-sun gao-sun merged commit 82408b6 into master Mar 18, 2024
19 checks passed
@gao-sun gao-sun deleted the gao-shared-default-universal branch March 18, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better size/l
Development

Successfully merging this pull request may close these issues.

2 participants