-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add POST /configs/jwt-customizer/test API #5525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
Name | Diff |
---|---|
packages/core/package.json | 0 Bytes |
packages/core/src/routes/logto-config.openapi.json | 📈 +1.86 KB |
packages/core/src/routes/logto-config.ts | 📈 +1.31 KB |
packages/core/src/routes/swagger/index.ts | 📈 +297 Bytes |
packages/core/src/routes/swagger/utils/general.ts | 📈 +1.49 KB |
packages/schemas/src/types/jwt-customizer.ts | 0 Bytes |
pnpm-lock.yaml | 📈 +429 Bytes |
darcyYe
force-pushed
the
yemq-log-8444-add-jwt-customizer-test-api
branch
from
March 19, 2024 05:04
7ec40d8
to
abc39eb
Compare
darcyYe
force-pushed
the
yemq-log-8338-update-extra-token-claims-logic
branch
from
March 19, 2024 05:39
b66a5ca
to
9b7872f
Compare
darcyYe
force-pushed
the
yemq-log-8444-add-jwt-customizer-test-api
branch
from
March 19, 2024 05:41
abc39eb
to
8fb087b
Compare
simeng-li
reviewed
Mar 19, 2024
darcyYe
force-pushed
the
yemq-log-8338-update-extra-token-claims-logic
branch
from
March 19, 2024 08:21
9b7872f
to
8ea5a6b
Compare
gao-sun
reviewed
Mar 19, 2024
gao-sun
reviewed
Mar 19, 2024
gao-sun
reviewed
Mar 19, 2024
gao-sun
reviewed
Mar 19, 2024
simeng-li
reviewed
Mar 19, 2024
darcyYe
force-pushed
the
yemq-log-8444-add-jwt-customizer-test-api
branch
from
March 19, 2024 08:57
8fb087b
to
3f5c626
Compare
simeng-li
reviewed
Mar 19, 2024
darcyYe
force-pushed
the
yemq-log-8444-add-jwt-customizer-test-api
branch
from
March 19, 2024 09:01
3f5c626
to
22f8676
Compare
darcyYe
changed the base branch from
yemq-log-8338-update-extra-token-claims-logic
to
master
March 19, 2024 09:02
darcyYe
changed the title
feat(core): add POST /configs/jwt-customizer/test API
feat(core): add POST /configs/jwt-customizer/:tokenPathType/test API
Mar 19, 2024
darcyYe
force-pushed
the
yemq-log-8444-add-jwt-customizer-test-api
branch
from
March 19, 2024 10:04
80708bd
to
30ae906
Compare
4 tasks
darcyYe
changed the title
feat(core): add POST /configs/jwt-customizer/:tokenPathType/test API
feat(core): add POST /configs/jwt-customizer/test API
Mar 20, 2024
gao-sun
reviewed
Mar 20, 2024
darcyYe
force-pushed
the
yemq-log-8444-add-jwt-customizer-test-api
branch
from
March 20, 2024 05:31
f6f9a16
to
70875f3
Compare
simeng-li
reviewed
Mar 20, 2024
simeng-li
reviewed
Mar 20, 2024
simeng-li
previously approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
gao-sun
force-pushed
the
yemq-log-8444-add-jwt-customizer-test-api
branch
4 times, most recently
from
March 20, 2024 15:30
fbad393
to
ba625d2
Compare
gao-sun
reviewed
Mar 20, 2024
darcyYe
force-pushed
the
yemq-log-8444-add-jwt-customizer-test-api
branch
from
March 21, 2024 02:58
0dfd5af
to
b2e00df
Compare
gao-sun
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add POST /configs/jwt-customizer/test API.
Since the custom JWT is a cloud 'service' and should be init by Logto core backend, we need to add this API to forward the console cloud service request.
Testing
Tested locally, since this API relies on cloud service API, will add tests to Cloud service API.
Checklist
- [ ].changeset
- [ ] unit tests- [ ] integration tests- [ ] necessary TSDoc comments