Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add POST /configs/jwt-customizer/test API #5525

Merged
merged 11 commits into from
Mar 21, 2024

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Mar 19, 2024

Summary

Add POST /configs/jwt-customizer/test API.
Since the custom JWT is a cloud 'service' and should be init by Logto core backend, we need to add this API to forward the console cloud service request.

Testing

Tested locally, since this API relies on cloud service API, will add tests to Cloud service API.
image

Checklist

- [ ] .changeset
- [ ] unit tests
- [ ] integration tests
- [ ] necessary TSDoc comments

Copy link

github-actions bot commented Mar 19, 2024

COMPARE TO master

Total Size Diff 📈 +5.36 KB

Diff by File
Name Diff
packages/core/package.json 0 Bytes
packages/core/src/routes/logto-config.openapi.json 📈 +1.86 KB
packages/core/src/routes/logto-config.ts 📈 +1.31 KB
packages/core/src/routes/swagger/index.ts 📈 +297 Bytes
packages/core/src/routes/swagger/utils/general.ts 📈 +1.49 KB
packages/schemas/src/types/jwt-customizer.ts 0 Bytes
pnpm-lock.yaml 📈 +429 Bytes

@github-actions github-actions bot added feature Cool stuff size/s labels Mar 19, 2024
@darcyYe darcyYe force-pushed the yemq-log-8444-add-jwt-customizer-test-api branch from 7ec40d8 to abc39eb Compare March 19, 2024 05:04
@darcyYe darcyYe force-pushed the yemq-log-8338-update-extra-token-claims-logic branch from b66a5ca to 9b7872f Compare March 19, 2024 05:39
@darcyYe darcyYe force-pushed the yemq-log-8444-add-jwt-customizer-test-api branch from abc39eb to 8fb087b Compare March 19, 2024 05:41
@darcyYe darcyYe force-pushed the yemq-log-8338-update-extra-token-claims-logic branch from 9b7872f to 8ea5a6b Compare March 19, 2024 08:21
@darcyYe darcyYe force-pushed the yemq-log-8444-add-jwt-customizer-test-api branch from 8fb087b to 3f5c626 Compare March 19, 2024 08:57
@darcyYe darcyYe force-pushed the yemq-log-8444-add-jwt-customizer-test-api branch from 3f5c626 to 22f8676 Compare March 19, 2024 09:01
@darcyYe darcyYe changed the base branch from yemq-log-8338-update-extra-token-claims-logic to master March 19, 2024 09:02
@darcyYe darcyYe changed the title feat(core): add POST /configs/jwt-customizer/test API feat(core): add POST /configs/jwt-customizer/:tokenPathType/test API Mar 19, 2024
@darcyYe darcyYe force-pushed the yemq-log-8444-add-jwt-customizer-test-api branch from 80708bd to 30ae906 Compare March 19, 2024 10:04
@darcyYe darcyYe changed the title feat(core): add POST /configs/jwt-customizer/:tokenPathType/test API feat(core): add POST /configs/jwt-customizer/test API Mar 20, 2024
@github-actions github-actions bot added size/m and removed size/s labels Mar 20, 2024
@darcyYe darcyYe force-pushed the yemq-log-8444-add-jwt-customizer-test-api branch from f6f9a16 to 70875f3 Compare March 20, 2024 05:31
@github-actions github-actions bot added size/s and removed size/m labels Mar 20, 2024
simeng-li
simeng-li previously approved these changes Mar 20, 2024
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

@github-actions github-actions bot added size/m and removed size/s labels Mar 20, 2024
@gao-sun gao-sun dismissed simeng-li’s stale review March 20, 2024 14:11

we have updates on API docs

@gao-sun gao-sun force-pushed the yemq-log-8444-add-jwt-customizer-test-api branch 4 times, most recently from fbad393 to ba625d2 Compare March 20, 2024 15:30
@darcyYe darcyYe force-pushed the yemq-log-8444-add-jwt-customizer-test-api branch from 0dfd5af to b2e00df Compare March 21, 2024 02:58
@darcyYe darcyYe enabled auto-merge March 21, 2024 04:53
@darcyYe darcyYe merged commit 5c6af38 into master Mar 21, 2024
19 checks passed
@darcyYe darcyYe deleted the yemq-log-8444-add-jwt-customizer-test-api branch March 21, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants