Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(phrases,core,console): update API and console error handling/display #5546

Merged

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Mar 24, 2024

Summary

Update:

  1. the error handling of core POST /configs/jwt-customizer/test API
  2. the error message should in console when testing custom JWT code snippet

Testing

Tested locally.
image
image
image

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Mar 24, 2024

COMPARE TO master

Total Size Diff 📈 +4.96 KB

Diff by File
Name Diff
packages/console/src/pages/JwtClaims/SettingsSection/TestTab.tsx 📈 +643 Bytes
packages/core/src/routes/logto-config.ts 📈 +625 Bytes
packages/phrases/src/locales/de/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/de/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/en/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/en/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/es/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/es/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/fr/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/fr/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/it/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/it/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/ja/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/ja/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/ko/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/ko/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/pl-pl/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/pl-pl/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/pt-br/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/pt-br/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/pt-pt/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/pt-pt/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/ru/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/ru/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/tr-tr/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/tr-tr/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/zh-cn/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/zh-cn/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/zh-hk/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/zh-hk/errors/jwt-customizer.ts 📈 +186 Bytes
packages/phrases/src/locales/zh-tw/errors/index.ts 📈 +68 Bytes
packages/phrases/src/locales/zh-tw/errors/jwt-customizer.ts 📈 +186 Bytes

@darcyYe darcyYe force-pushed the yemq-log-8470-update-custom-jwt-test-api-error-handling branch 2 times, most recently from 0da8023 to 5f92afa Compare March 25, 2024 06:03
@darcyYe darcyYe force-pushed the yemq-log-8470-update-custom-jwt-test-api-error-handling branch from 5f92afa to 9e67b67 Compare March 25, 2024 06:18
Base automatically changed from yemq-log-8338-update-extra-token-claims-logic to master March 25, 2024 06:28
@darcyYe darcyYe enabled auto-merge March 25, 2024 09:26
@darcyYe darcyYe force-pushed the yemq-log-8470-update-custom-jwt-test-api-error-handling branch from 291dff4 to 6143755 Compare March 25, 2024 09:38
@darcyYe darcyYe merged commit 62bd784 into master Mar 25, 2024
18 checks passed
@darcyYe darcyYe deleted the yemq-log-8470-update-custom-jwt-test-api-error-handling branch March 25, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better size/m
Development

Successfully merging this pull request may close these issues.

3 participants