Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(schemas,core): update custom JWT sample token payload guard #5558

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Mar 26, 2024

Summary

  1. update custom JWT sample token payload guard, add some fields not defined in OIDC token type but provided by Logto OIDC provider in real cases;
  2. make the custom JWT token sample payload as .strict() guard, since even if user give some extra fields in sample token payload, we will not provide that in real case. This could avoid misleading.
  3. Filter undefined fields in custom JWT main flow when getting the read only raw token payload.

Testing

N/A

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Mar 26, 2024

COMPARE TO master

Total Size Diff 📉 -1.69 KB

Diff by File
Name Diff
packages/console/src/pages/JwtClaims/utils/config.tsx 📉 -224 Bytes
packages/core/src/oidc/init.ts 📉 -85 Bytes
packages/schemas/src/types/logto-config/oidc-provider.ts 📉 -2 KB

@darcyYe darcyYe force-pushed the yemq-log-8448-update-sample-token-payload branch from 128cc95 to bf7aac5 Compare March 26, 2024 07:40
@darcyYe darcyYe marked this pull request as draft March 26, 2024 07:48
@darcyYe darcyYe force-pushed the yemq-log-8448-update-sample-token-payload branch 3 times, most recently from d473e83 to c9ed8d8 Compare March 27, 2024 04:00
@darcyYe darcyYe marked this pull request as ready for review March 27, 2024 04:03
@darcyYe darcyYe force-pushed the yemq-log-8448-update-sample-token-payload branch from c9ed8d8 to e0123fd Compare March 28, 2024 03:24
@darcyYe darcyYe enabled auto-merge March 28, 2024 03:24
@darcyYe darcyYe force-pushed the yemq-log-8448-update-sample-token-payload branch from 661c6f0 to 18041a6 Compare March 28, 2024 04:01
@github-actions github-actions bot added size/m and removed size/s labels Mar 28, 2024
@darcyYe darcyYe merged commit 664c67d into master Mar 28, 2024
19 checks passed
@darcyYe darcyYe deleted the yemq-log-8448-update-sample-token-payload branch March 28, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants