Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,test,schemas): add GET /configs/jwt-customizer API #5575

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Mar 28, 2024

Summary

  1. Add GET /configs/jwt-customizer API to get all jwt customizers in a single API call.
  2. Reorg and separate logto-config APIs into files.

Testing

Covered by unit tests and integration tests.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Mar 28, 2024

COMPARE TO master

Total Size Diff 📈 +5.64 KB

Diff by File
Name Diff
packages/core/src/mocks/index.ts 📈 +284 Bytes
packages/core/src/libraries/cloud-connection.test.ts 📈 +32 Bytes
packages/core/src/libraries/logto-config.ts 📈 +753 Bytes
packages/core/src/libraries/sign-in-experience/index.test.ts 📈 +32 Bytes
packages/core/src/routes/init.ts 📈 +6 Bytes
packages/core/src/routes/logto-config.openapi.json 📈 +8.41 KB
packages/core/src/routes/logto-config.test.ts 📈 +9.93 KB
packages/core/src/routes/logto-config.ts 📈 +11.16 KB
packages/core/src/routes/logto-config/index.test.ts 📈 +7.33 KB
packages/core/src/routes/logto-config/index.ts 📈 +5.63 KB
packages/core/src/routes/logto-config/jwt-customizer.test.ts 📈 +4.12 KB
packages/core/src/routes/logto-config/jwt-customizer.ts 📈 +6.44 KB
packages/core/src/routes/logto-config/logto-config.openapi.json 📈 +8.7 KB
packages/integration-tests/src/mocks/jwt-customizer.ts 📈 +293 Bytes
packages/integration-tests/src/api/logto-config.ts 📈 +154 Bytes
packages/integration-tests/src/tests/api/logto-config.test.ts 📈 +1.03 KB
packages/schemas/src/types/logto-config/index.ts 📈 +389 Bytes

@github-actions github-actions bot added enhancement Make it better size/xl labels Mar 28, 2024
@darcyYe darcyYe force-pushed the yemq-log-8507-add-GET-configs-jwt-customizers-API branch 2 times, most recently from 5966f1e to 7f270aa Compare March 28, 2024 08:47
@darcyYe darcyYe marked this pull request as ready for review March 28, 2024 08:47
@darcyYe darcyYe force-pushed the yemq-log-8507-add-GET-configs-jwt-customizers-API branch 2 times, most recently from 72639fd to facba7d Compare March 28, 2024 09:23
Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title should start with "feat"?

@darcyYe darcyYe changed the title refactor(core): reorg and separate logto-config APIs into files feat(core,test,schemas): add GET /configs/jwt-customizer API Mar 29, 2024
@github-actions github-actions bot added the feature Cool stuff label Mar 29, 2024
@darcyYe
Copy link
Contributor Author

darcyYe commented Mar 29, 2024

The PR title should start with "feat"?

Updated, the title was following the first commit message.

@darcyYe darcyYe force-pushed the yemq-log-8507-add-GET-configs-jwt-customizers-API branch 3 times, most recently from 7fda4c0 to cb16094 Compare March 29, 2024 08:08
@darcyYe darcyYe force-pushed the yemq-log-8507-add-GET-configs-jwt-customizers-API branch from cb16094 to c1722c8 Compare March 31, 2024 06:51
@darcyYe darcyYe enabled auto-merge March 31, 2024 06:56
@darcyYe darcyYe merged commit ceeeeb0 into master Mar 31, 2024
19 checks passed
@darcyYe darcyYe deleted the yemq-log-8507-add-GET-configs-jwt-customizers-API branch March 31, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better feature Cool stuff size/xl
Development

Successfully merging this pull request may close these issues.

2 participants