chore(core,console,schemas): update variable name and field name #5617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
wangsijie,
charIeszhao,
gao-sun and
simeng-li
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/pages/CustomizeJwt/CreateButton/index.tsx | 📈 +6 Bytes |
| packages/console/src/pages/CustomizeJwt/CustomizerItem/index.tsx | 📈 +9 Bytes |
| packages/console/src/pages/CustomizeJwt/index.tsx | 📈 +15 Bytes |
| packages/console/src/pages/CustomizeJwt/utils/path.ts | 📈 +9 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/MainContent/ScriptSection/index.tsx | 📈 +6 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/MainContent/SettingsSection/InstructionTab/index.tsx | 📈 +9 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/MainContent/SettingsSection/TestTab/index.tsx | 📈 +6 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/MainContent/index.tsx | 📈 +9 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/PageLoadingSkeleton/index.tsx | 📈 +9 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/index.tsx | 📈 +6 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/type.ts | 📈 +21 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/use-data-fetch.ts | 📈 +6 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/utils/format.ts | 📈 +64 Bytes |
| packages/console/src/pages/CustomizeJwtDetails/utils/path.ts | 📈 +6 Bytes |
| packages/core/src/mocks/index.ts | 📈 +26 Bytes |
| packages/core/src/oidc/init.ts | 📈 +142 Bytes |
| packages/core/src/routes/logto-config/jwt-customizer.ts | 📈 +269 Bytes |
| packages/core/src/routes/logto-config/logto-config.openapi.json | 📈 +39 Bytes |
| packages/integration-tests/src/mocks/jwt-customizer.ts | 📈 +13 Bytes |
| packages/schemas/src/types/logto-config/jwt-customizer.test.ts | 📈 +26 Bytes |
| packages/schemas/src/types/logto-config/jwt-customizer.ts | 📈 +262 Bytes |
charIeszhao
approved these changes
Apr 2, 2024
darcyYe
force-pushed
the
yemq-log-8449-log-8489-update-enum-type-name-and-field-name
branch
2 times, most recently
from
0902ecc
to
c4a09c0
Compare
wangsijie
approved these changes
Apr 3, 2024
darcyYe
force-pushed
the
yemq-log-8449-log-8489-update-enum-type-name-and-field-name
branch
from
c4a09c0
to
bde2abe
Compare
darcyYe
deleted the
yemq-log-8449-log-8489-update-enum-type-name-and-field-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename:
LogtoJwtTokenPathtoLogtoJwtTokenKeyType.envVarsfield in JWT customizer to beenvironmentVariables.Since this is a breaking change, we have to add some manual type casting. Will remove those temporary type casting after the @logto/cloud repo update the dependency and publish new release.
Testing
N/A. Secured by CI.
Checklist
.changeset