Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(console,toolkit): update custom JWT details page code editor action buttons style #5623

Merged

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Apr 2, 2024

Summary

Update custom JWT details page code editor action buttons style:

  1. Add isLeftMarginIgnored config for <CopyToClipboard /> component, all icon variant component come with left margin, which is not always wanted.
  2. Add overlay/dark_bg colors (including hover, pressed and focues)
  3. Update action buttons (reset, copy) icon color, gap, and hover/pressed style.

Testing

Tested locally.
image
image
image
image

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Apr 2, 2024

COMPARE TO master

Total Size Diff 📈 +1.38 KB

Diff by File
Name Diff
packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/ActionButton/CodeRestoreButton.tsx 📈 +178 Bytes
packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/ActionButton/index.module.scss 📈 +72 Bytes
packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.module.scss 📈 +550 Bytes
packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.tsx 📈 +128 Bytes
packages/toolkit/core-kit/scss/_console-themes.scss 📈 +482 Bytes

Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, better wait for approval of @charIeszhao

Base automatically changed from yemq-log-8592-prd-697-prd-699-prd-702-fix-console to master April 3, 2024 01:48
@darcyYe darcyYe enabled auto-merge April 3, 2024 03:30
@darcyYe darcyYe merged commit 7fecc0f into master Apr 3, 2024
19 checks passed
@darcyYe darcyYe deleted the yemq-prd-700-prd-701-fix-code-editor-action-button-styles branch April 3, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants