Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(console): use route objects #5698

Merged
merged 1 commit into from
Apr 12, 2024
Merged

refactor(console): use route objects #5698

merged 1 commit into from
Apr 12, 2024

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Apr 12, 2024

Summary

change from <Route /> to RouteObject. this is better for route management, and the only way to fetch the match pattern (/applications/:id instead of /applications/foo) dynamically.

there are some upcoming pulls:

  • split the huge root object into files
  • move all <Route /> in src/pages to the hook dir

Testing

  • no import change (i.e. no missing component)
  • locally previewed, clicked around ok
  • should pass all existing tests

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Apr 12, 2024

COMPARE TO master

Total Size Diff 📈 +282 Bytes

Diff by File
Name Diff
packages/console/src/containers/ConsoleContent/index.tsx 📈 +11.61 KB
packages/console/src/hooks/use-console-routes/index.tsx ⚠️ 📈 +11.89 KB

@gao-sun gao-sun marked this pull request as ready for review April 12, 2024 11:03
@gao-sun gao-sun requested a review from a team April 12, 2024 11:04
@gao-sun gao-sun merged commit 6ee37a7 into master Apr 12, 2024
19 checks passed
@gao-sun gao-sun deleted the gao-use-route-object branch April 12, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants