Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add organization jit role api tests #6026

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Jun 14, 2024

Summary

  • improve koaPagination types
  • fix api docs
  • add api tests

Testing

the pull itself

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions github-actions bot added the enhancement Make it better label Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

COMPARE TO master

Total Size Diff 📈 +6.29 KB

Diff by File
Name Diff
packages/core/src/middleware/koa-pagination.test.ts 📈 +7 Bytes
packages/core/src/middleware/koa-pagination.ts 📈 +1019 Bytes
packages/core/src/routes/organization/index.jit.roles.openapi.json 📈 +52 Bytes
packages/core/src/routes/organization/index.ts 📈 +32 Bytes
packages/core/src/routes/sso-connector/index.ts 📈 +44 Bytes
packages/core/src/utils/SchemaRouter.ts 📈 +266 Bytes
packages/integration-tests/src/api/organization-jit.ts 📈 +1.86 KB
packages/integration-tests/src/api/organization.ts 📈 +938 Bytes
packages/integration-tests/src/tests/api/admin-user.organization-jit.test.ts 📈 +4 Bytes
packages/integration-tests/src/tests/api/hook/hook.trigger.custom.data.test.ts 📈 +8 Bytes
packages/integration-tests/src/tests/api/interaction/organization-jit.test.ts 📈 +4 Bytes
packages/integration-tests/src/tests/api/organization/organization-email-domains.test.ts 📈 +3.04 KB
packages/integration-tests/src/tests/api/organization/organization-jit.test.ts 📈 +6.99 KB

@gao-sun gao-sun marked this pull request as ready for review June 14, 2024 14:55
Base automatically changed from gao-org-jit-roles to master June 17, 2024 03:51
@gao-sun gao-sun enabled auto-merge June 17, 2024 03:52
@gao-sun gao-sun merged commit 59fe21a into master Jun 17, 2024
31 of 32 checks passed
@gao-sun gao-sun deleted the gao-org-jit-roles-tests branch June 17, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better size/l
Development

Successfully merging this pull request may close these issues.

2 participants