Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: organization logo #6192

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: organization logo #6192

merged 1 commit into from
Jul 8, 2024

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Jul 7, 2024

Summary

  • upload and remove organization logo in console
  • support sign-in parameter organization_id for overriding the logo with the organization's

Testing

  • manual tests
  • integration tests added

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions github-actions bot added the feature Cool stuff label Jul 7, 2024
Copy link

github-actions bot commented Jul 7, 2024

COMPARE TO master

Total Size Diff ⚠️ 📈 +11.11 KB

Diff by File
Name Diff
.changeset/dull-goats-help.md 📈 +1.03 KB
.changeset/lazy-geese-bow.md 📈 +74 Bytes
packages/connectors/connector-mock-social/src/index.ts 📈 +4 Bytes
packages/console/src/hooks/use-user-assets-service.ts 📈 +638 Bytes
packages/console/src/pages/OrganizationDetails/Settings/Branding.tsx 📈 +2.45 KB
packages/console/src/pages/OrganizationDetails/Settings/index.module.scss 📈 +68 Bytes
packages/console/src/pages/OrganizationDetails/Settings/index.tsx 📈 +66 Bytes
packages/console/src/pages/OrganizationDetails/Settings/utils.ts 📈 +256 Bytes
packages/core/src/libraries/sign-in-experience/index.test.ts 📈 +60 Bytes
packages/core/src/libraries/sign-in-experience/index.ts 📈 +804 Bytes
packages/core/src/oidc/utils.ts 📈 +222 Bytes
packages/core/src/routes/well-known.ts 📈 +227 Bytes
packages/demo-app/src/App.tsx 📈 +257 Bytes
packages/demo-app/src/DevPanel.tsx 📈 +412 Bytes
packages/demo-app/src/utils.ts 📈 +191 Bytes
packages/experience/src/apis/settings.ts 📈 +88 Bytes
packages/experience/src/utils/search-parameters.ts 📈 +597 Bytes
packages/integration-tests/src/constants.ts 📈 +4 Bytes
packages/integration-tests/src/tests/api/admin-user.test.ts 📈 +8 Bytes
packages/integration-tests/src/tests/api/sign-in-experience.test.ts 📈 +12 Bytes
packages/integration-tests/src/tests/experience/overrides.test.ts 📈 +2.18 KB
packages/phrases/src/locales/en/translation/admin-console/organization-details.ts 📈 +335 Bytes
packages/phrases/src/locales/en/translation/admin-console/sign-in-exp/index.ts 0 Bytes
packages/schemas/alterations/next-1720253939-add-organization-branding.ts 📈 +452 Bytes
packages/schemas/src/consts/oidc.ts 📈 +466 Bytes
packages/schemas/src/foundations/jsonb-types/sign-in-experience.ts 📈 +275 Bytes
packages/schemas/tables/application_sign_in_experiences.sql 📈 +3 Bytes
packages/schemas/tables/organizations.sql 📈 +119 Bytes

@github-actions github-actions bot added the size/l label Jul 7, 2024
@gao-sun gao-sun force-pushed the gao-support-org-logo-for-sie branch from 62f82c6 to 0558dc0 Compare July 7, 2024 04:13
@gao-sun gao-sun changed the base branch from gao-refactor-image-uploader to master July 7, 2024 04:13
@gao-sun gao-sun force-pushed the gao-support-org-logo-for-sie branch 5 times, most recently from bb8016d to c691ce9 Compare July 7, 2024 13:22
@gao-sun gao-sun force-pushed the gao-support-org-logo-for-sie branch from c691ce9 to 3a839f6 Compare July 7, 2024 13:40
@gao-sun gao-sun marked this pull request as ready for review July 7, 2024 13:56
@gao-sun gao-sun merged commit 51be195 into master Jul 8, 2024
36 checks passed
@gao-sun gao-sun deleted the gao-support-org-logo-for-sie branch July 8, 2024 05:15
Copy link
Contributor

@xiaoyijun xiaoyijun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants