Malformed lines bug #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2019 18:12
asafm
suggested changes
Aug 21, 2019
logzio-sender/src/main/java/io/logz/sender/HttpsSyncSender.java
Outdated
Show resolved
Hide resolved
logzio-sender/src/main/java/io/logz/sender/HttpsSyncSender.java
Outdated
Show resolved
Hide resolved
logzio-sender/src/main/java/io/logz/sender/HttpsSyncSender.java
Outdated
Show resolved
Hide resolved
asafm
reviewed
Aug 22, 2019
| @@ -86,8 +87,10 @@ public void handle(String target, Request baseRequest, HttpServletRequest reques | |||
| logger.debug("got log: {} ", line); | |||
| }); | |||
| logger.debug("Total number of logRequests {} ({})", logRequests.size(), logRequests); | |||
|
|
|||
| // Tell Jetty we are ok, and it should return 200 | |||
| } catch (IllegalArgumentException e) { | |||
There was a problem hiding this comment.
Shouldn't this be a Jackson exception here?
There was a problem hiding this comment.
Why? I'm catching exceptions from LogRequest function
logzio-sender/src/main/java/io/logz/sender/HttpsSyncSender.java
Outdated
Show resolved
Hide resolved
logzio-sender/src/main/java/io/logz/sender/HttpsSyncSender.java
Outdated
Show resolved
Hide resolved
logzio-sender/src/main/java/io/logz/sender/HttpsSyncSender.java
Outdated
Show resolved
Hide resolved
logzio-sender/src/main/java/io/logz/sender/HttpsSyncSender.java
Outdated
Show resolved
Hide resolved
| @@ -110,6 +110,31 @@ public void simpleAppending() throws Exception { | |||
| mockListener.assertLogReceivedIs(message2, token, type, loggerName, LOGLEVEL); | |||
| } | |||
|
|
|||
| @Test | |||
| public void malformedBulk() throws Exception { | |||
There was a problem hiding this comment.
This test failed before the change and now it passes?
|
@asafm |
yyyogev
reviewed
Aug 29, 2019
| } | ||
| else if (responseCode == HttpURLConnection.HTTP_OK) { | ||
| reporter.info("Successfully sent bulk to logz.io, size: " + payload.length); | ||
| } else { |
There was a problem hiding this comment.
perhaps retry only if response code == 5xx?
asafm
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug:
When we receive a bad request from the listener we try to send the bulk again. This creates duplicate logs in case we have valid JSON objects in that bulk that the listener processed properly(resend of valid json too).